Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for more archive types using 7zip #9633

Merged
merged 60 commits into from
Aug 4, 2022
Merged

Add support for more archive types using 7zip #9633

merged 60 commits into from
Aug 4, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Aug 1, 2022 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Added support for browsing and editing rar, 7z, zip archives

TODO:

  • Fix renaming folders
  • Test in Release mode

Validation
How did you test these changes?

  • Built and ran the app

gave92 added 30 commits December 15, 2021 20:22
@gave92
Add to zip without loading into memory
247bc5a
@gave92
Fix SharpZipLib project
ec319cf
@gave92
Removed sharpziplib project
2de6443
@gave92
Added modified SharpZipLib nuget to project
c763b3c
@gave92
Fix opening empty archives
699779a
@gave92
Add 7ZipExtractor
a9d1e2f
@gave92
[WIP]
0c5b13b
@gave92
Restored browsing zips
fb9fd04
@gave92
Call uwp LoadPackagedLibrary
a6ff71d
@gave92
Open 7z, zip, rar
9976146
@gave92
Properly dispose streams & detect failed ops
85f6aaf
@gave92
Restore extract commands
15b07ab
@gave92
Removed unnecessary enconding detection
230f3f0
@gave92
[WIP] Add preference to open archives in Files
485c546
@gave92
Show icons in 7z files
02849e2
@gave92
Load correct size icon and overlay (#7052)
5b0a8b7
@gave92
[TEST] Switch to SevenZipSharp
6de4468
@gave92
Avoid crash on password protected archives
a3b83fb
@gave92
Cache file association per extension
2ef78e8
@gave92
[WIP] create file
365c487
@gave92
[WIP] Rename and delete
3fa44ad
@gave92
[WIP] Add file compression
da335d9
@gave92
Overwrite file only if compression succeedes
69dca8c
@gave92
Fix InputStreamWithDisposeCallback
2d3283f
@gave92
Revert changes to language files
e099315
@gave92
Conditional uwp support
397acbd
@gave92
Updated to new project structure
9b08324
@gave92
Merge branch 'main' of https://github.com/files-community/Files into …
6f170cb 
…7zip
@gave92
Fix build
e4f7e5a
@gave92
[TEST] Fix Azure build
6666353
@gave92 gave92 marked this pull request as ready for review August 1, 2022 23:28
@gave92 gave92 changed the title [TEST] 7zip Add support for more archive types using 7zip Aug 1, 2022
@gave92 gave92 mentioned this pull request Aug 1, 2022
Closed
@yaira2
Copy link
Member

yaira2 commented Aug 2, 2022 •
edited
Loading

How would an option to open archives in Files work? I'm pretty sure Microsoft prefers that we let users change the default on their own.

Or use Files only if set as default for that particular extension?

I'm leaning towards this but if there is a supported way to change the defaults for the other ones, it wouldn't hurt to add an option.

@yaira2
Copy link
Member

yaira2 commented Aug 2, 2022

Some additional feedback I got was that we can add shell extensions to File Explorer for extra visibility.

@yaira2 yaira2 requested review from yaira2 and d2dyno1 August 3, 2022 14:24
bbbhksgj
bbbhksgj previously approved these changes Aug 3, 2022
View reviewed changes
yaira2
yaira2 previously approved these changes Aug 4, 2022
View reviewed changes
@yaira2 yaira2 dismissed stale reviews from bbbhksgj and themself via 1ee83e2 August 4, 2022 13:13
yaira2
yaira2 approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Aug 4, 2022
@yaira2 yaira2 merged commit ace64fb into main Aug 4, 2022
@yaira2 yaira2 deleted the 7zip branch August 4, 2022 18:46
@gave92 gave92 mentioned this pull request Aug 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbbhksgj bbbhksgj bbbhksgj approved these changes

@d2dyno1 d2dyno1 d2dyno1 approved these changes

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gave92 @yaira2 @d2dyno1 @bbbhksgj