Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix properties navigation background #1974

Merged

Conversation

Thomas1664
Copy link
Contributor

This PR doesn't fix #1689 immediately because NavigationView doesn't allow you to override the background if PaneDisplayMode is set to Top. This bug is related to WinUI. For more information, see this issue. However, you can see that this fix works if you set PaneDisplayMode to Left.

@ghost ghost added the needs - code review label Sep 27, 2020
@yaira2
Copy link
Member

yaira2 commented Sep 27, 2020

@Thomas1664 Starting with #1962, we are going to use a pivot instead, @winiston2212 can you confirm if switching to a pivot will solve this issue?

@winston-de
Copy link
Contributor

winston-de commented Sep 27, 2020

@yaichenbaum I was in the process of switching to a Pivot View, but stopped after realizing that tabs cannot be hidden using a Pivot View (this would cause a crash if the user tried to access a tab like shortcut settings after selecting multiple files). Sorry for the confusion.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Sep 27, 2020
@yaira2 yaira2 merged commit 85556cf into files-community:master Sep 27, 2020
@Thomas1664 Thomas1664 deleted the fix-properties-navigation-background branch September 27, 2020 17:59
@marcelwgn
Copy link
Contributor

@yaichenbaum @Thomas1664 NavigationView uses the "NavigationViewTopPaneBackground" resource for the background of the NavigationView when display mode is set to top. It is possible to customize the background through that resource similar to "NavigationViewDefaultPaneBackground".

@yaira2
Copy link
Member

yaira2 commented Sep 29, 2020

@chingucoding Thank you for letting us know, also great to see you here 😃.

ChihweiLHBird pushed a commit to ChihweiLHBird/files-uwp that referenced this pull request Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Acrylic background is not shown for the navigation view pane in properties window
4 participants