Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where launching Files from Terminal didn't use the correct path #16642

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Dec 22, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Type "files-dev.exe ." and check it opens in current terminal folder

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Dec 22, 2024
@yaira2 yaira2 changed the title Fix: Fixed launching Files from terminal in the current folder Fix: Fixed issue where launching Files from terminal didn't use the correct path Dec 22, 2024
@yaira2 yaira2 merged commit 0a4266e into files-community:main Dec 22, 2024
6 checks passed
@yaira2 yaira2 changed the title Fix: Fixed issue where launching Files from terminal didn't use the correct path Fix: Fixed issue where launching Files from Terminal didn't use the correct path Dec 22, 2024
@Josh65-2201
Copy link
Member

Would this also apply to #14381

@gave92 gave92 deleted the issue_dot_cmd branch December 22, 2024 15:41
@gave92
Copy link
Member Author

gave92 commented Dec 22, 2024

Would this also apply to #14381

Ah yes, it looks the same 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Typing "files-dev.exe ." in terminal does not open current folder
3 participants