Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed crash that would occur when starting Files from WSL directories #16617

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Dec 18, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Run "files-dev.exe ." from wsl

@gave92 gave92 changed the title Set content root dir for HostBuilder Fix: Fixed crash if startup folder is a wsl directory Dec 18, 2024
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Dec 19, 2024
@yaira2 yaira2 changed the title Fix: Fixed crash if startup folder is a wsl directory Fix: Fixed crash that would occur when starting Files from WSL directories Dec 19, 2024
@yaira2 yaira2 merged commit 0093c5e into files-community:main Dec 19, 2024
6 checks passed
@gave92 gave92 deleted the issue_15772 branch December 19, 2024 07:41
yaira2 added a commit that referenced this pull request Dec 20, 2024
yaira2 added a commit that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Files crashes if startup folder is wsl directory
2 participants