Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Removed NOTICE.md link from Files.App.csproj #15542

Merged
merged 7 commits into from
Jun 10, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jun 3, 2024

Resolved / Related Issues

We can expect appx. 38kB reduction in size.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Open Files app
  2. Settings > About > Third party libraries expander

image

@yaira2 yaira2 self-requested a review June 4, 2024 02:02
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 10, 2024
@yaira2 yaira2 merged commit 65ee0b1 into files-community:main Jun 10, 2024
6 checks passed
@yaira2
Copy link
Member

yaira2 commented Jun 10, 2024

Thank you

@0x5bfa 0x5bfa deleted the 5bfa/CQ-RemoveNoticeMd branch June 12, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants