Code Quality: Adding the possibility of plural translation using ICU format

[XTorLukas]

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

• For Feature: Plural and singular translation without complex implementation #15323

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

1. Testing plural implementation for text strings using ICU format
2. Adding for all necessary strings

Screenshot

[XTorLukas]

How to use it

Plural.ItemsSelected.Text -> {0, plural, one {# item selected} other {# items selected}}

// Auto incremental placeholder '0' 0,1,...
"Plural/ItemsSelected/Text".GetLocalizedFormatResource(selectedItems.Count);
// OR
"Plural/ItemsSelected/Text".GetLocalizedFormatResource(0.ToFormatPairs(selectedItems.Count));
// OR
"Plural/ItemsSelected/Text".GetLocalizedFormatResource("0".ToFormatPairs(selectedItems.Count));
// OR
"Plural/ItemsSelected/Text".GetLocalizedFormatResource(new Dictionary<string, object?>() { ["0"] = selectedItems.Count });

Results:

0 items selected
1 item selected
2 items selected
...
10 items selected

Plural.ItemsCount.Text -> {0, plural, one {item} other {items}}

// Auto incremental placeholder '0' 0,1,...
"Plural/ItemsCount/Text".GetLocalizedFormatResource(FilesystemViewModel.FilesAndFolders.Count);
// OR
"Plural/ItemsCount/Text".GetLocalizedFormatResource(0.ToFormatPairs(FilesystemViewModel.FilesAndFolders.Count));
// OR
"Plural/ItemsCount/Text".GetLocalizedFormatResource("0".ToFormatPairs(FilesystemViewModel.FilesAndFolders.Count));
// OR
"Plural/ItemsCount/Text".GetLocalizedFormatResource(new Dictionary<string, object?>() { ["0"] = FilesystemViewModel.FilesAndFolders.Count });

Results:

items
item
items
...
items

[XTorLukas]

Okay I'm done, we could try just these two for now, we'll see how the translators handle it. I could finish the others in the next PR

[XTorLukas]

Okay I'm done, we could try just these two for now, we'll see how the translators handle it. I could finish the others in the next PR

It might be a good idea to add a link to the basic usage documentation in Crowdin's details: Crowdin ICU Message Syntax | Plural

[0x5bfa]

Codebase quality reviews.
If you’ve tested in en-US for them, LGTM.
Japanese doesn’t have this kind of difference(singular and plural).

[0x5bfa]

I’m not sure why but there’re duplicated functionalities including RespurceString, GetLocalized, GetLocalizedResource, LocalizationService, and this.
We have to refactor…

[XTorLukas]

Codebase quality reviews. If you’ve tested in en-US for them, LGTM. Japanese doesn’t have this kind of difference(singular and plural).

If not necessary, only 'other' is used https://www.unicode.org/cldr/charts/45/supplemental/language_plural_rules.html#ja

{0, plural, other {# アイテム}}

[XTorLukas]

If you’ve tested in en-US for them,

I always test en-US (two options) and cs-CZ (three options) using plural

[yaira2]

LGTM