-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Fixed an issue where the home key wouldn't move focus when renaming items in List View #15225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pressing the Home key several times now returns the cursor to the top of the textbox, but pressing it once still only returns the cursor to the top of the visible area.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have found this PR makes it impossible to select text with Shift+Up or Shift+Down.
Does changing back to |
KeyDown will make the selection, but only to the middle of the text box, not to the beginning or end of the text box in case of Grid/Tiles/List view. Also, the original issue will no longer be fixed. |
@nunescostr Could you address those issues above? Let me know if you hardly have time to tackle with them. |
Right now I am struggling to find the time, but I can look into this closer to next month's time |
2e4f94d
to
98eb6b4
Compare
@nunescostr are you still planning to work on this? |
Summary
The Home and end key weren't being acknowledged by the textBox.Keydown on the List View, Grid View and Tile View Layouts. To fix this I replaced it with textBox.PreviewKeyDown, this way the handling is not being consumed before it reaches the controller. I had to implement specific handling for these keys on the switch case already implemented on the GridLayoutPage.xaml.cs.
Resolved / Related Issues
Closes Bug: Home key doesn't move to the 1st character when renaming item in List View layout #15048
Validation
How did you test these changes?
None.
Screenshots (optional)
None.