Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where drag and drop from Edge didn't work #14976

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Drag and drop from browser doesn't work #14008

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Download a file with Edge.
    2. Drag the downloaded file from the Downloads flyout and drop it to Files.
    3. The operation now works.

@0x5bfa
Copy link
Member

0x5bfa commented Mar 18, 2024

Would it be better to add issue number to the comments?

@hishitetsu
Copy link
Member Author

Would it be better to add issue number to the comments?

Added.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 18, 2024
@yaira2 yaira2 merged commit d50ed7c into files-community:main Mar 18, 2024
6 checks passed
@hishitetsu hishitetsu deleted the DropFromEdge branch March 18, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Drag and drop from browser doesn't work
3 participants