Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Qaulity: Introduce Shimmer #14897

Closed
wants to merge 8 commits into from

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Mar 4, 2024

Summary

Internal planning.

  • Added Shimmer control
  • Use it in every layout page

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes #issue
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Go to a folder with any layout
    2. Re-load
    3. WmSee Shimmer!

Screenshots

None

@yaira2 yaira2 force-pushed the 5bfa/Introduce-WCTLabs branch 2 times, most recently from 6cb08ea to c0a8a51 Compare March 4, 2024 21:34
@yaira2 yaira2 force-pushed the 5bfa/Introduce-WCTLabs branch from c0a8a51 to b9926bd Compare March 4, 2024 23:19
@yaira2 yaira2 force-pushed the 5bfa/Introduce-WCTLabs branch from 53fa3e5 to 9b04e02 Compare March 5, 2024 15:26
@yaira2
Copy link
Member

yaira2 commented Mar 6, 2024

@0x5bfa thank you for your help on this PR, I included these changes in #14905.

@yaira2 yaira2 closed this Mar 6, 2024
@yaira2
Copy link
Member

yaira2 commented Mar 6, 2024

This will be replaced with the official version after updating the Toolkit to 8.1.

@0x5bfa 0x5bfa deleted the 5bfa/Introduce-WCTLabs branch March 6, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants