Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Replaced icon height & size constants with enums #14809

Merged
merged 6 commits into from
Feb 23, 2024
Merged

Code Quality: Replaced icon height & size constants with enums #14809

merged 6 commits into from
Feb 23, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Feb 22, 2024 •
edited
Loading

Summary

Planned internally.

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    None

Screenshots

None

@0x5bfa 0x5bfa marked this pull request as ready for review February 22, 2024 08:16
@yaira2 yaira2 self-requested a review February 22, 2024 16:00
@yaira2 yaira2 force-pushed the 5bfa/Add-ItemSizeEnum branch 15 times, most recently from 2999a6c to eb06ec2 Compare February 23, 2024 01:04
@yaira2 yaira2 force-pushed the 5bfa/Add-ItemSizeEnum branch from 3dd6264 to 47a93e5 Compare February 23, 2024 01:09
yaira2
yaira2 previously approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 23, 2024
0x5bfa
0x5bfa commented Feb 23, 2024
View reviewed changes
Copy link
Member Author

@0x5bfa 0x5bfa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn' need Icon in DetailsViewIconSizeKind (all of them)?

Otherwise, looks great.

src/Files.Core/Data/Enums/GridViewSizeKind.cs Show resolved Hide resolved
@yaira2
Rename
7ab6150 
Rename
@yaira2 yaira2 force-pushed the 5bfa/Add-ItemSizeEnum branch from 2bc9e5f to 7ab6150 Compare February 23, 2024 01:33
0x5bfa
0x5bfa commented Feb 23, 2024
View reviewed changes
Copy link
Member Author

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't approve bc this is mine but https://github.com/files-community/Files/labels/approved

@hishitetsu hishitetsu deleted the 5bfa/Add-ItemSizeEnum branch February 23, 2024 03:05
@hishitetsu hishitetsu restored the 5bfa/Add-ItemSizeEnum branch February 23, 2024 03:06
@yaira2 yaira2 merged commit 9743a4a into files-community:main Feb 23, 2024
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/Add-ItemSizeEnum branch February 23, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hishitetsu hishitetsu hishitetsu approved these changes

@yaira2 yaira2 Awaiting requested review from yaira2

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x5bfa @yaira2 @hishitetsu