Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed issue where icon overlays were cached #14727

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Fix: Fixed issue where icon overlays were cached #14727

merged 1 commit into from
Feb 15, 2024

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Feb 15, 2024 •
edited
Loading

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Icon overlays for folders/files in Google Drive don't update #13901...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
Add screenshots here.

yaira2
yaira2 commented Feb 15, 2024
View reviewed changes
src/Files.App/Helpers/BitmapHelper.cs
@@ -28,6 +28,7 @@ internal static class BitmapHelper
{
image.DecodePixelWidth = decodeSize;
image.DecodePixelHeight = decodeSize;
image.DecodePixelType = DecodePixelType.Logical;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated but it may have slight improvement for memory usage

yaira2
yaira2 commented Feb 15, 2024
View reviewed changes
src/Files.App/Utils/Shell/Win32API.cs
public byte[]? Icon { get; set; }

public byte[]? Overlay { get; set; }
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have the cache in ItemViewModel, is there any benefit in keeping this around?

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Feb 15, 2024
@yaira2 yaira2 merged commit 9e7d704 into main Feb 15, 2024
6 checks passed
@yaira2 yaira2 deleted the ya/Overlay branch February 21, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gave92 gave92 gave92 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Icon overlays for folders/files in Google Drive don't update
2 participants
@yaira2 @gave92