Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed high contrast support in menu flyouts #14664

Merged
merged 7 commits into from
Feb 9, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Feb 7, 2024

Summary

This PR contains abount two topic

  • Fix backplate issue on a flyout
  • Fix red coloring by adding "Brush" suffix

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Issue: Bug: Backplates will be displayed when hovering in High Contrast #13078
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Launch the app
    2. Right click a storage item
    3. See no backplates

Screenshots

Before After
image image
Before After
image image

@0x5bfa 0x5bfa changed the title Fix: Fixed an issue where the backplate persists on a flyout texts Fix: Fixed backplate issues Feb 7, 2024
@0x5bfa 0x5bfa marked this pull request as ready for review February 7, 2024 20:05
@0x5bfa 0x5bfa changed the title Fix: Fixed backplate issues Fix: Fixed blackplate issues Feb 7, 2024
@yaira2 yaira2 changed the title Fix: Fixed blackplate issues Fix: Fixed high contrast support in menu flyouts Feb 9, 2024
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Feb 9, 2024
@yaira2 yaira2 merged commit 9914ebb into files-community:main Feb 9, 2024
6 checks passed
@yaira2
Copy link
Member

yaira2 commented Feb 9, 2024

Thank you

@0x5bfa 0x5bfa deleted the 5bfa/Fix-BackplateOnFlyoutIssue branch February 13, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants