Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Replace foreach with Task.WhenAll #14657

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Code Quality: Replace foreach with Task.WhenAll #14657

merged 5 commits into from
Feb 7, 2024

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Feb 6, 2024 •
edited
Loading

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related Code quality: Await is being used inside foreach loop #10268...

Note
These changes were only made where the order of the tasks isn't important.

@yaira2 yaira2 requested a review from hishitetsu February 7, 2024 15:32
hishitetsu
hishitetsu approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Feb 7, 2024
@yaira2 yaira2 merged commit 763fd28 into main Feb 7, 2024
6 checks passed
@yaira2 yaira2 deleted the ya/TaskWhenAll branch February 7, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hishitetsu hishitetsu hishitetsu approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaira2 @hishitetsu