-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Fixed issue where updating the default layout wouldn't refresh open tabs #14651
Merged
yaira2
merged 9 commits into
files-community:main
from
ferrariofilippo:Fix_Layout_Doesn't_Update
Feb 7, 2024
Merged
Fix: Fixed issue where updating the default layout wouldn't refresh open tabs #14651
yaira2
merged 9 commits into
files-community:main
from
ferrariofilippo:Fix_Layout_Doesn't_Update
Feb 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
reviewed
Feb 5, 2024
Does this also work if the default layout is changed in Settings? |
hishitetsu
reviewed
Feb 5, 2024
Co-authored-by: hishitetsu <[email protected]>
|
yaira2
reviewed
Feb 6, 2024
yaira2
added
ready to merge
Pull requests that are approved and ready to merge
and removed
needs - code review
labels
Feb 6, 2024
yaira2
approved these changes
Feb 6, 2024
hishitetsu
approved these changes
Feb 7, 2024
yaira2
changed the title
Fix: Fixed layout doesn't update on open tabs when the default layout changes
Fix: Fixed issue where updating the default layout wouldn't update open tabs
Feb 7, 2024
yaira2
changed the title
Fix: Fixed issue where updating the default layout wouldn't update open tabs
Fix: Fixed issue where updating the default layout wouldn't refresh open tabs
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Closes Bug: Layout doesn't update on open tabs when the default layout changes #14580
Notes
The
if
at line 432 is not easily readable. Should I add a comment/split it, or is it fine?Validation
How did you test these changes?