Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where updating the default layout wouldn't refresh open tabs #14651

Merged

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

Notes
The if at line 432 is not easily readable. Should I add a comment/split it, or is it fine?

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Make sure Files settings > Folders > Sync layout and sorting preferences across directories is enabled
    2. Open two tab
    3. Change the layout in one tab
    4. Switch to the other

@yaira2
Copy link
Member

yaira2 commented Feb 5, 2024

Does this also work if the default layout is changed in Settings?

@ferrariofilippo
Copy link
Contributor Author

ferrariofilippo commented Feb 6, 2024

Does this also work if the default layout is changed in Settings?

Not yet but I'll work on that and on dual pane mode
Done

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Feb 6, 2024
@yaira2 yaira2 requested a review from hishitetsu February 6, 2024 19:18
@yaira2 yaira2 merged commit 1c2c9ab into files-community:main Feb 7, 2024
6 checks passed
@yaira2 yaira2 changed the title Fix: Fixed layout doesn't update on open tabs when the default layout changes Fix: Fixed issue where updating the default layout wouldn't update open tabs Feb 7, 2024
@yaira2 yaira2 changed the title Fix: Fixed issue where updating the default layout wouldn't update open tabs Fix: Fixed issue where updating the default layout wouldn't refresh open tabs Feb 7, 2024
@ferrariofilippo ferrariofilippo deleted the Fix_Layout_Doesn't_Update branch February 7, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Layout doesn't update on open tabs when the default layout changes
3 participants