Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed crash that would occur when Git path contained an emoji #14643

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Feb 4, 2024

Resolved / Related Issues

  • Fixed crash that would occur when Git path contained an emoji
StrictFilePathMarshaler.MarshalManagedToNative (Object managedObj)
/_/LibGit2Sharp/Core/FilePathMarshaler.cs, line 76
System.Text.EncoderFallbackException: Unable to translate Unicode character \\uDC83 at index 24 to specified code page

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but I think this is rather an issue with LibGit2Sharp)

@yaira2 yaira2 merged commit dde05f6 into main Feb 5, 2024
5 checks passed
@yaira2 yaira2 deleted the ya/EncoderFallbackException branch February 5, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants