Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where the app would crash when displaying a large number of items #14559

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Jan 27, 2024

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

@hishitetsu hishitetsu changed the title Fix: Fixed issue where the list view would crash when displaying a large number of items Fix: Fixed issue where the app would crash when displaying a large number of items Jan 27, 2024
@Mantej-Singh
Copy link

Mantej-Singh commented Jan 27, 2024

Patch is working fine on my PC
image

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jan 28, 2024
@yaira2 yaira2 merged commit 5297e3f into files-community:main Jan 28, 2024
6 checks passed
@hishitetsu hishitetsu deleted the hishitetsu-patch-1 branch January 28, 2024 03:01
@yaira2
Copy link
Member

yaira2 commented Jan 28, 2024

The downside of this change is that thumbnails take noticeably longer to load, is it possible to move up the thumbnail loading or will that contribute towards the crash?

@hishitetsu
Copy link
Member Author

It appears that it can be done. I will look a little more and submit another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Crash with List View layout Bug: Files crashes when scrolling up and down in a folder with 800+ files
3 participants