Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed issue where thumbnails would sometimes fail to load in OneDrive #14552

Merged
merged 5 commits into from
Jan 26, 2024
Merged

Fix: Fixed issue where thumbnails would sometimes fail to load in OneDrive #14552

merged 5 commits into from
Jan 26, 2024

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jan 25, 2024 •
edited
Loading

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Thumbnails don't refresh in OneDrive after being cached #14437...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Confirm file icon is displayed and then replaced once the thumbnail is loaded

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 changed the title Proof of concept: Loop OneDrive thumbnails until cached Fix: Fixed issue where thumbnails would sometimes fail to load in OneDrive Jan 25, 2024
@yaira2 yaira2 marked this pull request as ready for review January 25, 2024 21:50
@yaira2 yaira2 mentioned this pull request Jan 25, 2024
Closed
8 tasks
0x5bfa
0x5bfa reviewed Jan 26, 2024
View reviewed changes
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointed out some parts; otherwise LGTM!

src/Files.App/Utils/Shell/Win32API.cs Outdated Show resolved Hide resolved
src/Files.App/Utils/Shell/Win32API.cs Outdated Show resolved Hide resolved
src/Files.App/Utils/Shell/Win32API.cs Show resolved Hide resolved
@yaira2 yaira2 requested a review from hishitetsu January 26, 2024 15:20
hishitetsu
hishitetsu approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works for me!

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 26, 2024
@yaira2 yaira2 merged commit 5ff7f98 into main Jan 26, 2024
5 checks passed
@yaira2 yaira2 deleted the ya/OneDrivePoc branch January 26, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x5bfa 0x5bfa 0x5bfa left review comments

@hishitetsu hishitetsu hishitetsu approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Thumbnails don't refresh in OneDrive after being cached
3 participants
@yaira2 @0x5bfa @hishitetsu