Code Quality: Use LoadIconWithoutOverlayAsync for Drives Widget #14524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@foxnoodles @Mantej-Singh if you have Visual Studio, can you see if this fixes #14499? |
|
Trying it now. |
|
Good work. Working as expected. |
yaira2
force-pushed
the
ya/DrivesLoadIconWithoutOverlayAsync
branch
from
79df28b to
5b2267c
Compare
|
@Mantej-Singh thanks for checking! Can you check again with the latest commit and confirm if it's still good? |
|
@yaira2 |
|
The underlying issue is that the requested icon size (256) is missing from the ico file. Requesting a smaller size would reduce the quality of the other icons so that's not really an option. |
yaira2
force-pushed
the
ya/DrivesLoadIconWithoutOverlayAsync
branch
from
465958f to
ea0f437
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Related to #14499