Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed IOException in QuickLookProvider #14509

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Fix: Fixed IOException in QuickLookProvider #14509

merged 4 commits into from
Jan 22, 2024

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jan 21, 2024

Resolved / Related Issues

  • Handle IOException in QuickLookProvider

@yaira2 yaira2 requested a review from hishitetsu January 22, 2024 04:01
hishitetsu
hishitetsu reviewed Jan 22, 2024
View reviewed changes
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not call Close(), as the call to it may raise another exception.

src/Files.App/Services/PreviewPopupProviders/QuickLookProvider.cs Outdated Show resolved Hide resolved
src/Files.App/Services/PreviewPopupProviders/QuickLookProvider.cs Outdated Show resolved Hide resolved
hishitetsu
hishitetsu approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 22, 2024
@yaira2 yaira2 merged commit 8d5164f into main Jan 22, 2024
6 checks passed
@yaira2 yaira2 deleted the ya/IOException branch January 28, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hishitetsu hishitetsu hishitetsu approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaira2 @hishitetsu