Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Refactor InfoPane selection #14095

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Code Quality: Refactor InfoPane selection #14095

merged 2 commits into from
Nov 28, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 27, 2023 •
edited
Loading

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Thumbnail in details pane sometimes reloads #12877...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Opened details pane and confirmed it displayed the details/preview for the selected item
    2. Also confirmed it showed the info for the current folder when no items were selected
    3. Switched tabs and confirmed the pane updated based on the selected tab
    4. Switched focus between right & left pane and confirmed the info pane updated
    5. Restarted app with the pane enabled & continue where you left off, and confirmed it displayed the correct preview
    6. Confirmed the pane is only updated when it's enabled (confirmed by placing a breakpoint)

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 marked this pull request as draft November 27, 2023 19:20
@yaira2
Phase 1
b7f5a31 
Update PaneHolderPage.xaml.cs

Update PaneHolderPage.xaml.cs

Update InfoPaneViewModel.cs

Update InfoPaneViewModel.cs

Update InfoPaneViewModel.cs
@yaira2 yaira2 force-pushed the ya/InfoPaneSelection branch from c255061 to b7f5a31 Compare November 27, 2023 20:18
@yaira2 yaira2 requested a review from d2dyno1 November 27, 2023 21:14
@yaira2 yaira2 marked this pull request as ready for review November 27, 2023 21:14
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 28, 2023
@yaira2 yaira2 merged commit 0cd6cc3 into main Nov 28, 2023
6 checks passed
@yaira2 yaira2 deleted the ya/InfoPaneSelection branch November 28, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d2dyno1 d2dyno1 Awaiting requested review from d2dyno1

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Thumbnail in details pane sometimes reloads
1 participant
@yaira2