Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow deleting of local Git branches #14059

Merged
merged 4 commits into from
Nov 27, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Allow deleting of local Git branches #13592

Important

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open a git repo
    2. Click on the branch name in the status bar
    3. Click on Delete to delete a local branch
    4. Click on Cancel and make sure the branch is still there
    5. Repeat but click on Continue and check that the branch is deleted

Screenshots (optional)
image

@yaira2
Copy link
Member

yaira2 commented Nov 24, 2023

We still haven't finalized the design for this feature. I'll try to finish this up over the next few days.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 27, 2023
@yaira2 yaira2 merged commit e1be096 into files-community:main Nov 27, 2023
6 checks passed
@ferrariofilippo ferrariofilippo deleted the Delete_Git_Branches branch November 27, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Allow deleting of local Git branches
2 participants