Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Only show Google Drive under cloud drives #14041

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 23, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Add config section to settings to add/remove cloud drives #6795...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Confirm Google Drive is only displayed under Cloud Drives

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 force-pushed the ya/HideGoogleDrive branch from 780d349 to f2c53fa Compare November 23, 2023 21:06
Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 23, 2023
@yaira2 yaira2 merged commit bd78721 into main Nov 23, 2023
6 checks passed
@yaira2 yaira2 deleted the ya/HideGoogleDrive branch November 23, 2023 21:47
@A-Loot
Copy link
Contributor

A-Loot commented Nov 26, 2023

When I installed the update (3.0.12.0) it worked as intended but now the G drive is back.

Screenshot 2023-11-26 154215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add config section to settings to add/remove cloud drives
3 participants