Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Moved static methods from MainPageViewModel to NavigationHelpers #14027

Merged
merged 5 commits into from
Nov 24, 2023

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Nov 23, 2023

Summary

As the title

Task Checklist

  • Removed MainPageViewModel DI references

Steps To Validate Changes

  1. Launch the app
  2. Add a new tab
  3. Go to Home
  4. Go to a folder
  5. See tab info is being changed accordingly.

Known Issues

N/A

PR Checklist

  • Development: N/A
  • Approval: Have discussed with and got approval from the team1
  • Tests: Tested accessibility on the local end
  • Deployment: Deployed the app on the local end
  • Localization: Modified en-US string resources2
  • Co-authors: N/A

Screenshots

N/A

Footnotes

  1. If the request hasn't been agreed by the team, this work might be rejected. Make sure that you get approval from the team before opening any PR related the request.

  2. If you removed any en-US string resources, make sure that there are no references of those resources. When you add a new en-US string resources, do not make any changes on other languages' resources; Crowdin will do that, instead.

@0x5bfa 0x5bfa changed the title Code Quality: Removed MainPageViewModel DI references Code Quality: Moved static methods from MainPageViewModel to NavigationHelpers Nov 23, 2023
@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Nov 23, 2023
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Nov 24, 2023
@yaira2 yaira2 merged commit 237dca7 into files-community:main Nov 24, 2023
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/Cleanup-MainPageViewModel branch November 26, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants