Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Refactor preview/info pane phase 1 #13895

Merged
merged 6 commits into from
Nov 15, 2023
Merged

Code Quality: Refactor preview/info pane phase 1 #13895

merged 6 commits into from
Nov 15, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 15, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Details pane is missing the item properties #12964...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app and enable info pane
    2. Confirm that it works to switch between details & preview via the tabs as well as the keyboard shortcuts
    3. Confirm that the selected tab is restored even if the info pane is closed and reopened

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 marked this pull request as draft November 15, 2023 18:42
@yaira2 yaira2 marked this pull request as ready for review November 15, 2023 21:33
@yaira2 yaira2 changed the title Code Quality: Refactor preview/info pane phase 1 Code Quality: Refactor preview/info pane Nov 15, 2023
@yaira2 yaira2 changed the title Code Quality: Refactor preview/info pane Code Quality: Refactor preview/info pane phase 1 Nov 15, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Nov 15, 2023
@yaira2 yaira2 merged commit 4826f55 into main Nov 15, 2023
5 checks passed
@yaira2 yaira2 deleted the ya/InfoPane branch November 15, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Details pane is missing the item properties
1 participant