Fixed: Fixed issue where the new item dialog cannot be canceled #13846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
changed the title
yaira2
added
ready to merge
|
@MrFrawsty congrats on your first PR in the Files repo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Closes Bug: The new item dialog cannot be canceled #13787
Validation
How did you test these changes?
Did you build the app and test your changes?
Are there any other steps that were used to validate these changes?
The issue was the
viewModel.ResultType.ItemTypein theAddItemDIalogwas not being reset to the defaultResultType.ItemType.Canceland was remaining whatever type was last selected before pressing cancel. If there is another place I should reset it to cancel please let me know and I will revise it.