Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed issue where double-clicking on column headers would navigate up #13840

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Fix: Fixed issue where double-clicking on column headers would navigate up #13840

merged 2 commits into from
Nov 13, 2023

Conversation

RieBi
Copy link
Contributor

@RieBi RieBi commented Nov 13, 2023 •
edited
Loading

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Double-click on column header to go to parent folder #13789

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Are there any other steps that were used to validate these changes?
    1. Open app
    2. Open a folder
    3. Double click open space
    4. Confirm that it navigates to parent folder
    5. Double click column header
    6. Confirm that only ascending/descending order is being changed

@RieBi RieBi changed the title Fix the issue Fix: Fixed Double-click on column header to go to parent folder issue Nov 13, 2023
@yaira2 yaira2 changed the title Fix: Fixed Double-click on column header to go to parent folder issue Fix: Fixed issue where double-clicking on column headers would navigate up Nov 13, 2023
yaira2
yaira2 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix works for me, LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 13, 2023
@yaira2 yaira2 merged commit 515c476 into files-community:main Nov 13, 2023
6 checks passed
@yaira2
Copy link
Member

yaira2 commented Nov 13, 2023

@RieBi congrats on your first PR in the Files repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Double-click on column header to go to parent folder
2 participants
@RieBi @yaira2