Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Use OpenItem action for better reliability #13831

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Code Quality: Use OpenItem action for better reliability #13831

merged 2 commits into from
Nov 13, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 12, 2023 •
edited
Loading

Resolved / Related Issues
Switched NavigationHelpers.OpenSelectedItemsAsync to Commands.OpenItem.ExecuteAsync to take advantage of the checks in the action. It also makes the code a little more readable and gives us the confidence that the action will handle all the logic.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 13, 2023
@yaira2 yaira2 merged commit c440e68 into main Nov 13, 2023
5 checks passed
@yaira2 yaira2 deleted the ya/OpenItemCommand branch November 13, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yaira2