Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed crash that could occur when trying to open the settings file #13719

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Fix: Fixed crash that could occur when trying to open the settings file #13719

merged 1 commit into from
Nov 7, 2023

Conversation

d2dyno1
Copy link
Member

@d2dyno1 d2dyno1 commented Nov 7, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.

Validation
How did you test these changes?

  • Did you build the app and test your changes?

@d2dyno1 d2dyno1 requested a review from yaira2 November 7, 2023 20:01
yaira2
yaira2 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Fix for retrieving user settings file Fix: Fixed crash that could occur when trying to open the settings file Nov 7, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Nov 7, 2023
@yaira2 yaira2 merged commit 786a74d into files-community:main Nov 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d2dyno1 @yaira2