Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed Shell32.GetData COMException #13690

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Fix: Fixed Shell32.GetData COMException #13690

merged 1 commit into from
Nov 7, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 6, 2023

Resolved / Related Issues
https://appcenter.ms/orgs/FilesApp/apps/Files/crashes/errors/2623248240u/overview

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
Add screenshots here.

@yaira2
Copy link
Member Author

yaira2 commented Nov 6, 2023

This doesn't fix the underlying issue, but the hope is to get a better idea with the additional logging.

hishitetsu
hishitetsu approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 6ee2063 into main Nov 7, 2023
1 check passed
@yaira2 yaira2 deleted the ya/FixDragDropCOMException branch November 7, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hishitetsu hishitetsu hishitetsu approved these changes

Assignees
No one assigned
Labels
needs - code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaira2 @hishitetsu