Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Display basic preview in Details pane #13665

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 5, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Keep file previews to Preview tab, use Icons for details #12564...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Select Office file
    2. Display details pane
    3. Confirm basic thumbnail is shown
    4. Switch to preview pane
    5. Confirm the full preview is displayed

Screenshots (optional)
Add screenshots here.

@winston-de
Copy link
Contributor

Hey, it's been a while, hope all is well. I just wanted to say this is a great idea, will significantly improve loading times when a user wants a simple overview. It might be worth adding a shortcut to switch between the two, though, to make it easier for powerusers to switch without using the mouse. Maybe a shortcut like Alt+shift+p to access preview directly.

@yaira2
Copy link
Member Author

yaira2 commented Nov 6, 2023

@winston-de we can definitely do that, can you open a feature request to track?

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 6, 2023
@yaira2 yaira2 merged commit c3cb46d into main Nov 6, 2023
1 check passed
@yaira2 yaira2 deleted the ya/BasicPreviewDetails branch November 7, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Keep file previews to Preview tab, use Icons for details
2 participants