Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added support for canceling tab tear off #13642

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 1, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Esc to cancel tab tear off #10234...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open multiple tabs
    2. Drag tab outside the window and release mouse
    3. Confirm tab was teared off
    4. Drag tab outside window and press escape
    5. Confirm the drag operation is canceled

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 marked this pull request as draft November 1, 2023 22:33
@yaira2 yaira2 added help wanted Extra attention is needed needs - code review labels Nov 1, 2023
@yaira2 yaira2 force-pushed the ya/CancelTabTearoff branch from bcbcddb to bbc804e Compare November 2, 2023 18:42
@yaira2
Copy link
Member Author

yaira2 commented Nov 2, 2023

@gave92 can you try this out?

@gave92
Copy link
Member

gave92 commented Nov 2, 2023

Sry can't test it rn :(

** if you go with this version remember to unsubscribe the event, currently it registers multiple times.

@yaira2 yaira2 removed the help wanted Extra attention is needed label Nov 2, 2023
@yaira2 yaira2 marked this pull request as ready for review November 2, 2023 20:48
@gave92
Copy link
Member

gave92 commented Nov 3, 2023

This mostly works, it fails consistently only when pressing ESC while tab is over a second instance of Files. What issues did you experience with b92feed?

@yaira2
Copy link
Member Author

yaira2 commented Nov 3, 2023

This mostly works, it fails consistently only when pressing ESC while tab is over a second instance of Files

The other window is probably taking the focus, we could work around this by increasing the scope of the key press event but I think it's okay as is.

What issues did you experience with b92feed?

It would cancel the drag even without pressing esc.

@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 3, 2023
@yaira2 yaira2 force-pushed the ya/CancelTabTearoff branch from a0854c3 to b27a725 Compare November 3, 2023 14:20
@yaira2 yaira2 merged commit ee46960 into main Nov 3, 2023
1 check was pending
@yaira2 yaira2 deleted the ya/CancelTabTearoff branch November 3, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Esc to cancel tab tear off
2 participants