Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Switch focus to Files when activating window #13588

Merged
merged 6 commits into from
Oct 29, 2023
Merged

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Oct 27, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Switch focus to Files when using win+e #10844...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app and set as the default file manager
    2. Minimize window or switch focus to another window
    3. Use the open file location option in another app and see if Files is brought to the foreground

Screenshots (optional)
Add screenshots here.

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for one point.

src/Files.App/MainWindow.xaml.cs Outdated Show resolved Hide resolved
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 29, 2023
@yaira2 yaira2 merged commit 9372972 into main Oct 29, 2023
1 check passed
@yaira2 yaira2 deleted the ya/BringFocusToFiles branch October 29, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Switch focus to Files when using win+e
2 participants