Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Updated the design for startup settings #13503

Merged
merged 12 commits into from
Oct 13, 2023
Merged

Feature: Updated the design for startup settings #13503

merged 12 commits into from
Oct 13, 2023

Conversation

heftymouse
Copy link
Contributor

@heftymouse heftymouse commented Oct 11, 2023 •
edited by yaira2
Loading

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
image

@yaira2 yaira2 changed the title Feature: Update Open Specific Page(s) in Startup Settings Feature: Update the design for startup settings Oct 12, 2023
@yaira2 yaira2 changed the title Feature: Update the design for startup settings Feature: Updated the design for startup settings Oct 12, 2023
yaira2
yaira2 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit a91771a into files-community:main Oct 13, 2023
2 checks passed
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jay-o-Way Jay-o-Way Jay-o-Way left review comments

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heftymouse @yaira2 @Jay-o-Way