Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Updated strings #13432

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Feature: Updated strings #13432

merged 1 commit into from
Sep 26, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Sep 26, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Reduce unnecessary capitalizations #12854...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 merged commit 3830137 into main Sep 26, 2023
1 check was pending
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Sep 26, 2023
@yaira2 yaira2 deleted the ya/Strings branch September 26, 2023 21:20
@smarquespt
Copy link

smarquespt commented Sep 27, 2023

Lead to typo:
image

@smarquespt
Copy link

Another:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Reduce unnecessary capitalizations
2 participants