Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Improve tab icon resolution #13431

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Feature: Improve tab icon resolution #13431

merged 2 commits into from
Sep 26, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Sep 26, 2023

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Add new tab and browse to pinned folder
    2. Confirm icon resolution matches the sidebar

Screenshots (optional)
Add screenshots here.

@yaira2
Copy link
Member Author

yaira2 commented Sep 26, 2023

@Lukiluc29 do you want to check this out?

@yaira2 yaira2 merged commit 5f35984 into main Sep 26, 2023
1 check was pending
@yaira2 yaira2 deleted the ya/TabIcon branch September 26, 2023 21:20
@Lukiluc29
Copy link
Contributor

@Lukiluc29 do you want to check this out?

Yes, it's flawless! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Icon Resolution Discrepancy in File Explorer when Opening "Downloads" Folder
2 participants