Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where path name wasn't visible when grouping libraries by path #13409

Merged
merged 9 commits into from
Oct 9, 2023

Conversation

ashrafmansuri
Copy link
Contributor

@ashrafmansuri ashrafmansuri commented Sep 21, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Group by path in Libraries is missing path name #8144...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 changed the title Solved #8144 Fix: Fixed an issue where the path name wasn't visible when grouping libraries by path Sep 21, 2023
Copy link
Contributor Author

@ashrafmansuri ashrafmansuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made changes in GroupingHelper added method to check if it's a UNC path. Reverted changes in GroupedHeaderViewModel made earilier.

Copy link
Contributor Author

@ashrafmansuri ashrafmansuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check with Drives root folder and a Network Path.

src/Files.App/Utils/Storage/Collection/GroupingHelper.cs Outdated Show resolved Hide resolved
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for one minor point.

src/Files.App/Utils/Storage/Collection/GroupingHelper.cs Outdated Show resolved Hide resolved
Co-authored-by: hishitetsu <[email protected]>
@ashrafmansuri
Copy link
Contributor Author

LGTM except for one minor point.

Committed.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 9, 2023
@yaira2 yaira2 changed the title Fix: Fixed an issue where the path name wasn't visible when grouping libraries by path Fix: Fixed issue where path name wasn't visible when grouping libraries by path Oct 9, 2023
@yaira2
Copy link
Member

yaira2 commented Oct 9, 2023

@ashrafmansuri thank you for contributing to Files.

@yaira2 yaira2 merged commit 07e2a7d into files-community:main Oct 9, 2023
1 check passed
@ashrafmansuri
Copy link
Contributor Author

@ashrafmansuri thank you for contributing to Files.

You're welcome. 😄

@ashrafmansuri ashrafmansuri deleted the fix_groupbypathlibrary branch December 10, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Group by path in Libraries is missing path name
3 participants