-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Fixed issue where path name wasn't visible when grouping libraries by path #13409
Fix: Fixed issue where path name wasn't visible when grouping libraries by path #13409
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made changes in GroupingHelper added method to check if it's a UNC path. Reverted changes in GroupedHeaderViewModel made earilier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check with Drives root folder and a Network Path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for one minor point.
Co-authored-by: hishitetsu <[email protected]>
Committed. |
@ashrafmansuri thank you for contributing to Files. |
You're welcome. 😄 |
Resolved / Related Issues
Closes Bug: Group by path in Libraries is missing path name #8144...
Validation
How did you test these changes?
Screenshots (optional)
Add screenshots here.