Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added Support for Proton Drive #13401

Merged
merged 8 commits into from
Sep 24, 2023

Conversation

jacob-duff
Copy link
Contributor

@jacob-duff jacob-duff commented Sep 20, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Add support for "Proton Drive" (cloud drive) #12851

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Ensure Proton Drive is installed
    2. Open app ...
    3. Expand "Cloud Drives"
    4. Observe "Proton Drive" in the list
    5. Add a "test" folder in the Proton Drive web UI.
    6. Wait for sync, observe test folder in app.

Screenshots (optional)
Screenshot 2023-09-19 195633

Screenshot 2023-09-19 195627

@jacob-duff jacob-duff changed the title Feature 12851 Feature #12851 Sep 20, 2023
@jacob-duff jacob-duff changed the title Feature #12851 Add Support for Proton Drive Sep 20, 2023
@jacob-duff jacob-duff changed the title Add Support for Proton Drive Feature: Add Support for Proton Drive, Closes #12851 Sep 20, 2023
@yaira2 yaira2 requested a review from gave92 September 20, 2023 13:50
@yaira2 yaira2 changed the title Feature: Add Support for Proton Drive, Closes #12851 Feature: Added Support for Proton Drive Sep 20, 2023
@Silther
Copy link

Silther commented Sep 21, 2023

If you open Proton drive in the cloud drive section, which folder (path) gets opened?

@jacob-duff
Copy link
Contributor Author

If you open Proton drive in the cloud drive section, which folder (path) gets opened?

It opens the "my_drive" folder or something similar. You don't have to drill once you click "Proton Drive" in the side bar.

@hez2010
Copy link
Member

hez2010 commented Sep 22, 2023

Does Proton Drive allow to be installed to a customized path other than ProgramFiles? If yes we may need to change the detector to use a value from registry instead of the default ProgramFiles.

@jacob-duff
Copy link
Contributor Author

jacob-duff commented Sep 22, 2023

Does Proton Drive allow to be installed to a customized path other than ProgramFiles? If yes we may need to change the detector to use a value from registry instead of the default ProgramFiles.

Good point. I'll look into it.

Edit: It doesn't look like the Proton Drive installer gives an option to install to a separate location currently, but it would probably be wise to read from the registry regardless.

jacob-duff and others added 2 commits September 22, 2023 14:27
…les, or AppData sqlite files. Commit searches for install location, but can be reverted
@gave92
Copy link
Member

gave92 commented Sep 23, 2023

Hi! Please see jvestell#3 for a simpler approach for detecting Proton Drive. It's the same way we use already for detecting MEGA, iCloud, Amazon & others. No need to detect installed location or rely on proton's config files.

Use standard cloud drives reg location for proton
@jacob-duff
Copy link
Contributor Author

Hi! Please see jvestell#3 for a simpler approach for detecting Proton Drive. It's the same way we use already for detecting MEGA, iCloud, Amazon & others. No need to detect installed location or rely on proton's config files.

Looks great, thanks @gave92

@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Sep 23, 2023
@yaira2 yaira2 merged commit 07df65d into files-community:main Sep 24, 2023
1 check passed
@yaira2
Copy link
Member

yaira2 commented Sep 24, 2023

@nephi-duff thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add support for "Proton Drive" (cloud drive)
5 participants