Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: What's new popup #13269

Merged
merged 7 commits into from
Aug 29, 2023
Merged

Feature: What's new popup #13269

merged 7 commits into from
Aug 29, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Aug 28, 2023 •
edited
Loading

Resolved / Related Issues

  • Replace the What's new teaching tip with a popup

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Hardcoded IsReleaseNotesVisible to true
    2. Hard coded the markdown content
    3. Opened the popup

Screenshots (optional)
image

@yaira2 yaira2 requested a review from hishitetsu August 29, 2023 15:38
hishitetsu
hishitetsu reviewed Aug 29, 2023
View reviewed changes
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more point.

src/Files.Core/ViewModels/Dialogs/ReleaseNotesDialogViewModel.cs Outdated Show resolved Hide resolved
hishitetsu
hishitetsu approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@hishitetsu hishitetsu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in terms of codebase quality

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Aug 29, 2023
@yaira2 yaira2 merged commit 1db0e78 into main Aug 29, 2023
@yaira2 yaira2 deleted the ya/ReleaseNotes branch September 3, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hishitetsu hishitetsu hishitetsu approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaira2 @hishitetsu