Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Close all notification banners except in progress before sleep #13264

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

@hishitetsu hishitetsu changed the title Fix: Close all notification banners except in progress before sleep Feature: Close all notification banners except in progress before sleep Aug 28, 2023
yaira2
yaira2 previously approved these changes Aug 28, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Aug 28, 2023
@yaira2 yaira2 merged commit e945196 into files-community:main Aug 29, 2023
@hishitetsu hishitetsu deleted the CloseBannerBeforeSleep branch August 29, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Request to Disable Status Center Display in Background Mode for Files
2 participants