-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Quality: Added decorators property to the sidebar #13230
Code Quality: Added decorators property to the sidebar #13230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move ResourceDictionaries/SideBarResources.xaml to UserControls/SideBarControls.xaml?
Can you remove UserControls/Sidebar folder, which is not used anymore (that folder seems to be included in your initial PR incidentally)?
I don't really like having the eject button on the sidebar because when you have a lot of removable drives, it can quickly clutter the sidebar. So, I suggest implementing a button in the settings to enable or disable this functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolved / Related Issues
Closes #issue...
Validation
How did you test these changes?
Screenshots (optional)
Add screenshots here.