Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Added decorators property to the sidebar #13230

Merged
merged 17 commits into from
Aug 22, 2023

Conversation

marcelwgn
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes #issue...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 self-assigned this Aug 21, 2023
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move ResourceDictionaries/SideBarResources.xaml to UserControls/SideBarControls.xaml?
Can you remove UserControls/Sidebar folder, which is not used anymore (that folder seems to be included in your initial PR incidentally)?

@Lukiluc29
Copy link
Contributor

I don't really like having the eject button on the sidebar because when you have a lot of removable drives, it can quickly clutter the sidebar. So, I suggest implementing a button in the settings to enable or disable this functionality.

@yaira2 yaira2 marked this pull request as ready for review August 21, 2023 22:36
@yaira2 yaira2 changed the title Feat: Add SidebarItem decorators Code Quality: Added decorators property to the sidebar Aug 22, 2023
@yaira2 yaira2 removed their assignment Aug 22, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Aug 22, 2023
@yaira2 yaira2 merged commit 0d171cb into files-community:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants