Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added support for formatting drives from the properties window #13173

Merged
merged 6 commits into from
Sep 13, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

Details
As pointed out in #11607, Format... option is already visible in the main context menu of drives.
I added a Format button to the properties window of drives.
After #13142, Turn on BitLocker was visible in the main menu only when the drive required admin privileges; this PR fixes that bug

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open properties of a drive
    2. Click on Format...
    3. See that the format dialog pops up
    4. Right click on a USB stick and see that Turn on BitLocker is in the main menu

Screenshots (optional)
Screenshot 2023-08-10 110904

@yaira2
Copy link
Member

yaira2 commented Aug 10, 2023

Do we really want to add this to properties? I'm not against this option, but it's worth considering how useful it'll be when it can already be accessed from the context menu.

@ferrariofilippo
Copy link
Contributor Author

Honestly, I think it will be a niche feature: I don't think people format their drives frequently. I'd use this button whenever I want to check something in the properties of a drive before formatting it. If I am using the properties window, it's easier to use that button instead of going back to Files, right-clicking on the drive and then choosing formatting.
It might be useful for touch devices, where context menu is harder to use.
If you think we shouldn't add this button, I'll leave only the code to fix the bug with BitLocker

@yaira2
Copy link
Member

yaira2 commented Aug 10, 2023

I'd use this button whenever I want to check something in the properties of a drive before formatting it. If I am using the properties window

Makes sense 👍

@yaira2 yaira2 changed the title Fix: Format drive option is missing in properties Feature: Added support for formatting drives from the properties window Aug 16, 2023
@yaira2 yaira2 added changes requested Changes are needed for this pull request and removed needs - code review labels Sep 10, 2023
@yaira2 yaira2 added needs - code review and removed changes requested Changes are needed for this pull request labels Sep 12, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Sep 13, 2023
@yaira2 yaira2 merged commit 24aacea into files-community:main Sep 13, 2023
@ferrariofilippo ferrariofilippo deleted the Format_Drive_Option branch September 14, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Format drive option is missing
2 participants