Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Scroll to the selected file when using "Open file location" #13133

Merged

Conversation

ferrariofilippo
Copy link
Contributor

@ferrariofilippo ferrariofilippo commented Aug 5, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Select correct file when using "Open file location" #9390

Layout

  • Grid/Tiles -> Already implemented
  • Details -> Implemented in this PR
  • Columns ->Implemented in this PR

Other fixes

  • Open file location was not selecting any item in columns layout

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app
    2. Right click a shortcut
    3. Click on Open item location

@ferrariofilippo ferrariofilippo marked this pull request as draft August 5, 2023 21:40
@ferrariofilippo ferrariofilippo marked this pull request as ready for review August 6, 2023 07:44
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected.

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Aug 6, 2023
@yaira2 yaira2 merged commit 59be516 into files-community:main Aug 6, 2023
@ferrariofilippo ferrariofilippo deleted the Scroll_To_File_Open_File_Location branch August 6, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Select correct file when using "Open file location"
3 participants