Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed an issue where Git columns were incorrectly shown in search results #13111

Merged
merged 4 commits into from
Jul 31, 2023

Conversation

QuaintMako
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature? Yes, hidding the Git status bar as well.
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots

GitInfoHidden

Copy link
Contributor Author

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writing it thrice to be sure it won't be missed: the initial issue does not mention hiding the status bar as well. Yet if we want to be coherent, I believe we should mask it in the search result bar.

@yaira2 yaira2 changed the title Fix: Git Columns and status bar hidden in search result page Fix: Fixed an issue where Git columns were incorrectly shown in search results Jul 31, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jul 31, 2023
@yaira2 yaira2 merged commit b707b56 into files-community:main Jul 31, 2023
@QuaintMako QuaintMako deleted the 12927_HideGitInfoInSearchPage branch August 1, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Display Issue with Git Folder Search in Detail View
2 participants