Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Restored the status icon for the ongoing tasks #13097

Merged
merged 2 commits into from
Jul 30, 2023

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Jul 28, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: open "actions" flyout when action starts #13089

Validation
How did you test these changes?

  • Did you build the app and test your changes?

Screenshots (optional)
image

@yaira2 yaira2 changed the title Fix: Restore InfoBadge on OngoingTasks icon Fix: Restored the status icon for the ongoing tasks Jul 30, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jul 30, 2023
@yaira2 yaira2 merged commit 6e39707 into files-community:main Jul 30, 2023
@gave92 gave92 deleted the issue_13089 branch July 30, 2023 19:13
@mdtauk
Copy link
Contributor

mdtauk commented Jul 31, 2023

@yaira2 Did we want to take a look at revamping this icon/control design as per our older plan?
image
image

@yaira2
Copy link
Member

yaira2 commented Jul 31, 2023

@mdtauk I don't recall if we finalized those plans. In the meantime, this PR is only restoring existing functionality that broke when we switched to WinAppSdk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: open "actions" flyout when action starts
3 participants