-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Added a splash screen #12979
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@0x5bfa is this ready for review? 👀 |
yaira2
changed the title
Feature: Added the app Splash Screen
Feature: Added a splash screen
Jul 19, 2023
@0x5bfa this is working really well 🎉 Is the mica backdrop broken? |
This comment was marked as outdated.
This comment was marked as outdated.
@0x5bfa that's expected but it doesn't work for me at all, even after the app is fully loaded. |
OMG I made a terrible mistake, I can fix this. |
Ready for review. |
d2dyno1
reviewed
Jul 20, 2023
yaira2
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yaira2
added
ready to merge
Pull requests that are approved and ready to merge
and removed
needs - code review
labels
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Added the app Splash Screen
Motivation & Context
PR Checklist
Related Feature: Improving Performance, optimizations, reliability and codebase #4180
Screenshots
None