Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added a splash screen #12979

Merged
merged 10 commits into from
Jul 20, 2023
Merged

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jul 19, 2023

Feature: Added the app Splash Screen

Motivation & Context

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related Feature: Improving Performance, optimizations, reliability and codebase  #4180
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots

None

@yaira2
Copy link
Member

yaira2 commented Jul 19, 2023

@0x5bfa is this ready for review? 👀

@yaira2 yaira2 changed the title Feature: Added the app Splash Screen Feature: Added a splash screen Jul 19, 2023
@yaira2
Copy link
Member

yaira2 commented Jul 19, 2023

@0x5bfa this is working really well 🎉

Is the mica backdrop broken?

@yaira2 yaira2 requested a review from d2dyno1 July 19, 2023 15:05
@0x5bfa

This comment was marked as outdated.

@yaira2
Copy link
Member

yaira2 commented Jul 19, 2023

@0x5bfa that's expected but it doesn't work for me at all, even after the app is fully loaded.

@0x5bfa
Copy link
Member Author

0x5bfa commented Jul 19, 2023

OMG I made a terrible mistake, I can fix this.

@0x5bfa
Copy link
Member Author

0x5bfa commented Jul 20, 2023

Ready for review.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jul 20, 2023
@yaira2 yaira2 merged commit 248f3ff into files-community:main Jul 20, 2023
@0x5bfa 0x5bfa deleted the 5bfa/Add-SplashScreen branch July 20, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants