Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Increased maximum volume label length to 128 characters for UDF images #12931

Merged
merged 4 commits into from
Jul 12, 2023

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Jul 11, 2023

Resolved / Related Issues

NB: added a new nuget dependency (DiscUtils.Udf) as winapi GetVolumeInformation only returns up to 32 chars. I won't raise a fuss if PR is refused due to this :)

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Mount attached ISOs
    2. Check UDF formatted ISO label is > 32 characters

Screenshots (optional)
Screenshot 2023-07-10 003322

udf_long_name.zip

@gave92 gave92 changed the title Feature: Increase maximum read volume length to 128 characters (64 characters Unicode) for UDF File Systems Feature: Increase maximum volume label length to 128 characters for UDF File Systems Jul 11, 2023
@gave92 gave92 changed the title Feature: Increase maximum volume label length to 128 characters for UDF File Systems Feature: Increase maximum volume label length to 128 characters for UDF images Jul 11, 2023
@yaira2 yaira2 changed the title Feature: Increase maximum volume label length to 128 characters for UDF images Feature: Increased maximum volume label length to 128 characters for UDF images Jul 11, 2023
@yaira2
Copy link
Member

yaira2 commented Jul 11, 2023

added a new nuget dependency (DiscUtils.Udf) as winapi GetVolumeInformation only returns up to 32 chars. I won't raise a fuss if PR is refused due to this :)

I think adding this functionality is worth taking another dependency, how large is the package?

@gave92
Copy link
Member Author

gave92 commented Jul 12, 2023

Around 350KB, I've added the minimum needed for dealing with UDF.
image
The full library has more functionality, e.g create and extract ISO files and VHD disks.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit dae9d51 into files-community:main Jul 12, 2023
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jul 12, 2023
@gave92 gave92 deleted the udf branch July 12, 2023 16:06
@yaira2
Copy link
Member

yaira2 commented Nov 9, 2023

@gave92 is this working for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Increase maximum read volume length to 128 characters (64 characters Unicode) for UDF File Systems
2 participants