Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added "Properties" button to the Details Pane #12913

Merged

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Add "Edit properties" button to the Details pane #12796

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open the details pane
    2. Click on Properties

Screenshots (optional)
image

@Lukiluc29
Copy link
Contributor

Lukiluc29 commented Jul 10, 2023

Hello, I'm sorry for intruding into your commit, but I would like to know if it would be possible to move the button to the right instead of centering it in the preview pane?
Capture d'écran 2023-07-10 111652 (2)

@ferrariofilippo
Copy link
Contributor Author

Hello, I'm sorry for intruding into your commit, but I would like to know if it would be possible to move the button to the right instead of centering it in the preview pane?

I'd like to get more feedback before changing it

@yaira2
Copy link
Member

yaira2 commented Jul 10, 2023

The proposed design has it on the left, this way it lines up with the other details.

@yaira2 yaira2 changed the title Feature: Add properties button to the Details Pane Feature: Added "Properties" button to the Details Pane Jul 10, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jul 10, 2023
@yaira2 yaira2 merged commit a5d3844 into files-community:main Jul 10, 2023
@yaira2 yaira2 added feature request ready to merge Pull requests that are approved and ready to merge and removed ready to merge Pull requests that are approved and ready to merge feature request labels Jul 10, 2023
@ferrariofilippo ferrariofilippo deleted the Open_Properties_Preview_Pane branch July 10, 2023 14:59
@mdtauk
Copy link
Contributor

mdtauk commented Jul 10, 2023

Can we change the data for "Horizontal Resolution" and "Vertical Resolution" to be just

Resolution:
1920 × 1080 px

EDIT: Please note the use of the Multiplication symbol ×, and not the lowercase x

@ferrariofilippo
Copy link
Contributor Author

I agree, what do you think @yaira2

@yaira2
Copy link
Member

yaira2 commented Jul 10, 2023

Agreed, let's do that

@ferrariofilippo
Copy link
Contributor Author

Can we change the data for "Horizontal Resolution" and "Vertical Resolution" to be just

Resolution:
1920 × 1080 px

EDIT: Please note the use of the Multiplication symbol ×, and not the lowercase x

Actually, Horizontal Resolution and Vertical Resolution are not the "Dimension" of the image (like 1920 x 1080 px) but rather pixels/inch

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add "Edit properties" button to the Details pane
4 participants