Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Updated the toolbar icons #12895

Merged
merged 5 commits into from
Jul 7, 2023
Merged

Feature: Updated the toolbar icons #12895

merged 5 commits into from
Jul 7, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jul 7, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes #issue...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 marked this pull request as draft July 7, 2023 20:29
@yaira2 yaira2 changed the title Feature: Update icons Feature: Update toolbar icons Jul 7, 2023
@yaira2 yaira2 marked this pull request as ready for review July 7, 2023 20:37
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jul 7, 2023
@yaira2 yaira2 changed the title Feature: Update toolbar icons Feature: Updated the toolbar icons Jul 7, 2023
@yaira2 yaira2 merged commit dcc849d into main Jul 7, 2023
@yaira2 yaira2 deleted the ya/Icons branch July 7, 2023 21:50
hishitetsu
hishitetsu reviewed Jul 8, 2023
View reviewed changes
src/Files.App/UserControls/InnerNavigationToolbar.xaml
@@ -885,6 +882,29 @@
Style="{StaticResource RightAlignedToggleSwitchStyle}"
ToolTipService.ToolTip="{x:Bind Commands.ToggleShowFileExtensions.HotKeyText, Mode=OneWay}" />

<!-- Adaptive Layout -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bug in the changes regarding Adaptive layout.

  • Manually selecting a layout doesn't turn off the adaptive toggle.
  • If I turn off the adaptive toggle in this state, the layout is automatically selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hishitetsu hishitetsu hishitetsu left review comments

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaira2 @hishitetsu