Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Improved app startup routine #12861

Merged
merged 8 commits into from
Jul 9, 2023
Merged

Code Quality: Improved app startup routine #12861

merged 8 commits into from
Jul 9, 2023

Conversation

d2dyno1
Copy link
Member

@d2dyno1 d2dyno1 commented Jul 5, 2023 •
edited
Loading

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?

0x5bfa
0x5bfa approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

namespace corrections.

src/Files.Core/Models/IDatabaseModel.cs Outdated Show resolved Hide resolved
src/Files.Core/Models/ISerializedModel.cs Outdated Show resolved Hide resolved
src/Files.Core/AppModels/BaseDatabaseModel.cs Outdated Show resolved Hide resolved
src/Files.Core/AppModels/SingleFileDatabaseModel.cs Outdated Show resolved Hide resolved
@d2dyno1 d2dyno1 marked this pull request as ready for review July 7, 2023 21:51
@d2dyno1
Copy link
Member Author

d2dyno1 commented Jul 7, 2023

This is Phase 1 of startup routine improvements.
(More are on their way but will be in separate PRs to avoid conflicts)

@d2dyno1 d2dyno1 requested review from yaira2 and 0x5bfa July 7, 2023 21:52
@yaira2 yaira2 changed the title Improved app startup routine Code Quality: Improved app startup routine Jul 7, 2023
@yaira2 yaira2 merged commit db70e42 into files-community:main Jul 9, 2023
yaira2
yaira2 reviewed Jul 9, 2023
View reviewed changes
src/Files.App/App.xaml.cs
Comment on lines -33 to -35
using Microsoft.AppCenter;
using Microsoft.AppCenter.Analytics;
using Microsoft.AppCenter.Crashes;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still needed for AppCenter.

@yaira2 yaira2 mentioned this pull request Jul 9, 2023
Merged
@hishitetsu
Copy link
Member

This PR seems to be causing the following new exception. Once it occurs, it seems to loop hundreds of times.
image

@yaira2
Copy link
Member

yaira2 commented Jul 13, 2023

@d2dyno1

@d2dyno1
Copy link
Member Author

d2dyno1 commented Jul 14, 2023

I'll investigate

@yaira2 yaira2 mentioned this pull request Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@0x5bfa 0x5bfa Awaiting requested review from 0x5bfa

Assignees
No one assigned
Labels
needs - code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d2dyno1 @hishitetsu @yaira2 @0x5bfa