Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed crash that would occur when enabling the tags widget #12844

Merged
merged 3 commits into from
Jul 4, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Enable the tags widget.
    2. Open the home page.
    3. Adjust the window width so that the tags widgets are lined up vertically in a row.
    4. Repeat scrolling up and down.
    5. No more crash happens.

Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Files.App/UserControls/Widgets/FileTagsWidget.xaml Outdated Show resolved Hide resolved
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jul 4, 2023
@yaira2 yaira2 merged commit 77a4ae2 into files-community:main Jul 4, 2023
@hishitetsu hishitetsu deleted the FixLayoutCycleException branch July 4, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
3 participants